[Pkg-libvirt-commits] [libguestfs] 46/66: v2v: -o rhev: On failure path, use forking wrapper to clean up images dir.

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag debian/1%1.27.54-1
in repository libguestfs.

commit 0f4044b58fdc0693ce6db5925992386e3c453f23
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Tue Sep 23 15:36:12 2014 +0100

    v2v: -o rhev: On failure path, use forking wrapper to clean up images dir.
    
    Otherwise you get lots of errors like:
    
    rm: cannot remove ‘/var/tmp/mm/42f5e571-21af-44bd-8164-3ebe6bbc9f5a/images/7b28b0e6-79ce-4d78-a6cb-769760a3d373/31e2b06b-85cb-46ed-aac3-8bcef93dc704.meta’: Permission denied
    rm: cannot remove ‘/var/tmp/mm/42f5e571-21af-44bd-8164-3ebe6bbc9f5a/images/7b28b0e6-79ce-4d78-a6cb-769760a3d373/31e2b06b-85cb-46ed-aac3-8bcef93dc704’: Permission denied
    
    because the code is running as root.
---
 v2v/output_rhev.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml
index a8cffcb..f744afd 100644
--- a/v2v/output_rhev.ml
+++ b/v2v/output_rhev.ml
@@ -206,7 +206,7 @@ object
     at_exit (fun () ->
       if delete_target_directory then (
         let cmd = sprintf "rm -rf %s" (quote image_dir) in
-        ignore (Sys.command cmd)
+        Kvmuid.command kvmuid_t cmd
       )
     );
     if verbose then

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git