[Pkg-libvirt-commits] [libguestfs] 47/66: v2v: -o rhev: chmod the image so we will definitely be able to write to it.

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag debian/1%1.27.54-1
in repository libguestfs.

commit c9fdfe021cc13a7e3507adc65d23a84ef215e75c
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Tue Sep 23 15:42:05 2014 +0100

    v2v: -o rhev: chmod the image so we will definitely be able to write to it.
    
    NFS sucks.
---
 v2v/output_rhev.ml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml
index f744afd..47e7987 100644
--- a/v2v/output_rhev.ml
+++ b/v2v/output_rhev.ml
@@ -256,7 +256,13 @@ object
       fun () ->
         let g = new Guestfs.guestfs () in
         g#disk_create ?backingfile ?backingformat ?preallocation ?compat
-          ?clustersize path format size
+          ?clustersize path format size;
+        (* Make it sufficiently writable so that possibly root, or
+         * root squashed qemu-img will definitely be able to open it.
+         * An example of how root squashing nonsense makes everyone
+         * less secure.
+         *)
+        chmod path 0o666
     )
 
   (* This is called after conversion to write the OVF metadata. *)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git