[Pkg-libvirt-discuss] sheepdog (0.4.0-0+tek2b-6) testing; urgency=high

[Guido Günther]

(shortening the cc: list a bit)

On Wed, Jul 18, 2012 at 02:47:29PM +0200, Jens WEBER wrote:
> New unofficial debian packet for testing!
> 
>    deb http://tek2b.org/tek2b/debian/ wheezy/ 
> 
> sheepdog (0.4.0-0+tek2b-6) testing; urgency=high
> 
>   * deactivate stop function in startup init.d script
>       /etc/init.d/sheepdog stop
>       [warn] Stopping is unsafe, use instead: collie cluster shutdown (warning).
>     because sheep doesn't respond correctly on kill TERM (15) signal and crash.
> 
>  -- Jens Weber <jweber at tek2b.de>  Wed, 18 Jul 2012 14:23:29 +0200
> 
> git http://tek2b.org/git/projects/sheepdog.git
> http://tek2b.org/gitweb/?p=sheepdog.git;a=summary

Looking at that: why does the init script use eval and builds $PIDFILE
in several places? What's $2 supposed to contain? I assume it's for
multiple instandes. If it's empty SHEEP="_$SHEEP" evaluates to "_" which
looks wired. It should probably be described in the help output.

I'd also remove all the comments that come with the init.d template and
rather add comments describing what the script wants to do instead.

Cheers,
 -- Guido

> 
> Cheers Jens
>