[Pkg-libvirt-discuss] sheepdog (0.4.0-0+tek2b-6) testing; urgency=high

[Jens WEBER]

> Looking at that: why does the init script use eval and builds $PIDFILE
> in several places? What's $2 supposed to contain? I assume it's for
> multiple instandes. If it's empty SHEEP="_$SHEEP" evaluates to "_" which

can't happen
        SHEEP=$2
        if [ -z $SHEEP ]; then <- covers empty $2
                for SHEEP in for SHEEP in $SHEEPDOG_START_SEQUENCE; do
                ...
        else
                SHEEP="_$SHEEP" <- so $2 isn't empty
                ...
        fi

> looks wired. It should probably be described in the help output.

Yes and to check if $2 is a part of $SHEEPDOG_START_SEQUENCE would be nice too.
Anyway the $2 option is to start an stop a special instant. For example if one disc dies and the corresponding sheep instant muss be restarted. But I haven't test this scenario yet and the stop function is broken/unsafe. collie cluster shutdown stops all instants. So more testing is needed. 

> 
> I'd also remove all the comments that come with the init.d template and
> rather add comments describing what the script wants to do instead.

Yes, I agree in all points with you. Next step is code beauty and reduce redundant code.

Cheers Jens

> 
> Cheers,
>  -- Guido
> 
> > 
> > Cheers Jens
> > 
>