[Pkg-libvirt-maintainers] Bug#572449: should not assume that default SSH user is 'root'

[Piotr Lewandowski]

Package: virt-manager
Version: 0.8.3-2
Severity: normal

Hello,

When there is no user specified in SSH location virt-manager assumes that
'root' is the default user.

$ grep -B3 root /usr/share/virt-manager/virtManager/connect.py
        if conn == CONN_SSH and '@' in host:
            user, host = host.split('@',1)
        else:
            user = "root"

IMHO, not only this is counter-intuitive (because when I do `ssh <host>`
the assumed user is my local username) but also encourages bad practices
(login as root only to connect to libvirt's UNIX socket).

If user part is omitted, local username should be used instead.

Regards,
-- 
Piotr Lewandowski