[Pkg-libvirt-maintainers] Bug#572449: should not assume that default SSH user is 'root'

[Cole Robinson]

On 03/04/2010 05:32 AM, Piotr Lewandowski wrote:
> Package: virt-manager
> Version: 0.8.3-2
> Severity: normal
> 
> Hello,
> 
> When there is no user specified in SSH location virt-manager assumes that
> 'root' is the default user.
> 
> $ grep -B3 root /usr/share/virt-manager/virtManager/connect.py
>         if conn == CONN_SSH and '@' in host:
>             user, host = host.split('@',1)
>         else:
>             user = "root"
> 
> IMHO, not only this is counter-intuitive (because when I do `ssh <host>`
> the assumed user is my local username) but also encourages bad practices
> (login as root only to connect to libvirt's UNIX socket).
> 

I agree with your counterintuitive point, but I'd prefer to leave the
default as is: root is the user with the best chance of being able to
successfully connect to the remote libvirt daemon, and will just work
out of the box.

I think the fix here is to make the UI more explicit: for remote
connections, we should have a 'username' text field that is
automatically populated with 'root', so the user can see the default and
change if they want.