[Pkg-libvirt-maintainers] Bug#1075718: libvirt-clients: virsh domif-setlink fails to update state

[Cyril Brulebois]

Package: libvirt-clients
Version: 9.0.0-4
Severity: normal

Hi,

Working on some network-oriented tools (https://pts-project.org/), I
ended up wanting to down/up some network links from the virtualization
host (running libvirt, with the QEMU backend). The first step worked
just fine, the second step will surprise you:

    virsh # domif-setlink ViRogue --interface 52:54:00:03:73:13 --state down
    Device updated successfully
    
    virsh # domif-setlink ViRogue --interface 52:54:00:03:73:13 --state up
    error: Failed to update interface link state
    error: (device_definition):6: Attribute state redefined
          <link state="down" state="up"/>
    -----------------------------------^

The same happens with both 'up' and 'down', with or without --interface
and --state, and really looks like some basic logic bug somewhere in the
XML update code? (I haven't looked at the implementation just yet.)

That used to work fine but I couldn't say for sure which version(s) (as
I've run Debian 9 and Debian 11 previously, but with some backports); at
the time, I used that quite heavily to test bonding on virtualized
images with a lot of interfaces, without any such obvious issues.


Cheers,
-- 
Cyril Brulebois (kibi at debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant


-- System Information:
Debian Release: 12.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'proposed-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-22-amd64 (SMP w/20 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libvirt-clients depends on:
ii  libc6           2.36-9+deb12u7
ii  libgcc-s1       12.2.0-14
ii  libglib2.0-0    2.74.6-2+deb12u3
ii  libgnutls30     3.7.9-2+deb12u3
ii  libreadline8    8.2-1.3
ii  libvirt0        9.0.0-4
ii  libxml2         2.9.14+dfsg-1.3~deb12u1
ii  sensible-utils  0.0.17+nmu1

libvirt-clients recommends no packages.

Versions of packages libvirt-clients suggests:
pn  libvirt-clients-qemu  <none>
ii  libvirt-daemon        9.0.0-4
pn  libvirt-login-shell   <none>

-- no debconf information