Bug#956287: Problems identified in debian/copyright

[Michael Lustfield]

Package: llvm-toolchain-snapshot
Version: 11~++20200307074845+ec1d1f6ae70-1~exp1
Severity: serious

I noticed that this package appears to have some issues with debian/copyright.

Binary data exists with no indication that it can be rebuilt from source:
- lldb/unittests/ObjectFile/ELF/Inputs/early-section-headers.so
- lldb/unittests/Target/Inputs/TestModule.so
- soooooo many *.so files
- also many *.exe files
- Note: Test data is *not* excluded from DFSG.

These have a copyright/license that is not represented in d/copyright:
- lib/External/{many}
- llvm/utils/unittest/googletest/*
- llvm/utils/unittest/googlemock/*
- llvm/test/YAMLParser/*
- clang/lib/Headers/cuda_wrappers/*
- llvm/include/llvm/Support/MD5.h
  + Note: pseudonyms don't need to be represented; "2001 Alexander Peslyak
<solar at openwall.com>"
- clang/lib/Headers/:
  + avx512vlvp2intersectintrin.h
  + avx512vp2intersectintrin.h
- Note: This is not an exhaustive list.

libcxx/* indicates the wrong license *and* omits a copyright holder. (just
delete that paragraph) The same applies to polly/tools/GPURuntime/; it is
correctly represented when the paragraph is deleted).

clang/lib/Headers/* is represented as using Expat; this is not correct.

Multiple copyright blocks are mentioned for source that does not exist:
- lib/Support/reg*
- lldb/test/unittest2/*
- polly/lib/JSON/*
- test/YAMLParser/*
- utils/unittest/googletest/*

Note: If `polly/lib/JSON/` existed, "fixme" would have been unacceptable. It
should have copied LICENSE.txt.


Although not critical, the machine-readable copyright spec expects license
texts to either be with that paragraph or as an entirely unique paragraph. In
this case, it applies to BSD-3-Clause, expat, and u-of-i-bsd-like. Please see
missing-license-paragraph-in-dep5-copyright for additional information.

Also, it is not required to use four separate paragraphs;
"compiler-rt/lib/BlocksRuntime/*" is sufficient.

It is also possible to combine files:

Files:
  compiler-rt/lib/BlocksRuntime/*
  lldb/tools/debugserver/source/MacOSX/stack_logging.h
Copyright: 1999-2007 Apple Inc.
License: Apple


If you need further clarification, please don't hesitate to ask.