Bug#956287: Problems identified in debian/copyright

[Sylvestre Ledru]

Hello,

Bravo for the detective work.
I fixed the issues in llvm-toolchain-10.
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commits/10
will merge that in snapshot

Le 09/04/2020 à 13:17, Michael Lustfield a écrit :
> Package: llvm-toolchain-snapshot
> Version: 11~++20200307074845+ec1d1f6ae70-1~exp1
> Severity: serious
> 
> I noticed that this package appears to have some issues with debian/copyright.
thanks

> Binary data exists with no indication that it can be rebuilt from source:
> - lldb/unittests/ObjectFile/ELF/Inputs/early-section-headers.so
> - lldb/unittests/Target/Inputs/TestModule.so
> - soooooo many *.so files
> - also many *.exe files
> - Note: Test data is *not* excluded from DFSG.

It is a compiler. It is normal to have such files...
If they don't have sources, I don't think it is a big deal...
I can remove them but it will just degrade the quality of what we are shipping.

> These have a copyright/license that is not represented in d/copyright:
> - lib/External/{many}
there isn't any lib/ directory?

> - llvm/utils/unittest/googletest/*
Represented here:
https://sources.debian.org/src/llvm-toolchain-10/1:10.0.0-2/debian/copyright/#L119-L121
(the path moved)

> - llvm/utils/unittest/googlemock/*
done

> - llvm/test/YAMLParser/*
same as google test
https://sources.debian.org/src/llvm-toolchain-10/1:10.0.0-2/debian/copyright/#L97-L99

> - clang/lib/Headers/cuda_wrappers/*
done

> - llvm/include/llvm/Support/MD5.h
>    + Note: pseudonyms don't need to be represented; "2001 Alexander Peslyak
> <solar at openwall.com>"
fixed

> - clang/lib/Headers/:
>    + avx512vlvp2intersectintrin.h
>    + avx512vp2intersectintrin.h
done

> - Note: This is not an exhaustive list.


> libcxx/* indicates the wrong license *and* omits a copyright holder. (just
> delete that paragraph) 
Removed, thanks
 > The same applies to polly/tools/GPURuntime/; it is
> correctly represented when the paragraph is deleted).
ditto

> clang/lib/Headers/* is represented as using Expat; this is not correct.
fixed

> Multiple copyright blocks are mentioned for source that does not exist:
> - lib/Support/reg*
updated
(a lot of paths moved with the upstream svn => git migration)

> - lldb/test/unittest2/*
updated

> - polly/lib/JSON/*
removed

> - test/YAMLParser/*
updated

> - utils/unittest/googletest/*
updated
> 
> Note: If `polly/lib/JSON/` existed, "fixme" would have been unacceptable. It
> should have copied LICENSE.txt.
good it is removed :)

> 
> Although not critical, the machine-readable copyright spec expects license
> texts to either be with that paragraph or as an entirely unique paragraph. In
> this case, it applies to BSD-3-Clause, expat, and u-of-i-bsd-like. Please see
> missing-license-paragraph-in-dep5-copyright for additional information.
> 
> Also, it is not required to use four separate paragraphs;
> "compiler-rt/lib/BlocksRuntime/*" is sufficient.
> 
> It is also possible to combine files:
> 
> Files:
>    compiler-rt/lib/BlocksRuntime/*
>    lldb/tools/debugserver/source/MacOSX/stack_logging.h
> Copyright: 1999-2007 Apple Inc.
> License: Apple
thanks!