Bug#1021439: llvm-toolchain-14: Missing SPIR-V outputs in libclc-14

[Rob Savoury]

Package: src:llvm-toolchain-14
Version: 1:14.0.6-3
Severity: normal

Dear Maintainer,

The SPIR-V outputs have been missing from libclc-14 binary package for
a while, due renaming of the llvm-spirv binary by more recent versions
of src:spirv-llvm-translator{,-14} packages. The LLVM major version in
the build is now appended to the llvm-spirv binary name so this means
with src:spirv-llvm-translator >= 13.0.0-4 llvm-spirv -> llvm-spirv-13
whereas with src:spirv-llvm-translator-14 llvm-spirv -> llvm-spirv-14.

This renaming causes debian/rules in src:llvm-toolchain-14 to not set
LLVM_SPIRV_INSTALLED=yes as is clearly intended when the llvm-spirv
binary package (or llvm-spirv-14 package for newer LLVM 14 version) is
available as a build dep. Thus resulting in missing SPIR-V outputs.

In src:llvm-toolchain-15 this is already handled by two recent commits
[1] [2] but perhaps it would be good to also include a similar update
to debian/rules in src:llvm-toolchain-14? So that LLVM_SPIRV_INSTALLED
is set correctly resulting in SPIR-V outputs being built and included.

Note that the bug also affects recent src:llvm-toolchain-13 1:13.0.1-7
as found in testing/unstable due those building with recent versions
of spirv-llvm-translator. Though it does not affect the current stable
release (Bullseye) due to src:llvm-toolchain-13 being built against
older binaries from src:spirv-llvm-translator 11.0.0-1 prior to the
llvm-spirv renaming (which happened from src:spirv-llvm-translator-12
12.0.0-3 and src:spirv-llvm-translator 13.0.0-4 onwards).

[1] https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/b766a30
[2] https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/6cddfd8