[pkg-lxqt-devel] Bug#1034175: libfm-qt12: When connecting to an unknown host using ssh:// or sftp:// target, "Log In Anyway" button is ignored

[Julien ROBIN]

Package: libfm-qt12
Version: 1.2.1-1+b1
Severity: normal
X-Debbugs-Cc: julien.robin28 at free.fr

Dear Maintainer,

When connecting to ssh:// or sftp:// for the first time, a question message
appears, which is normal (described below). But the "Log In Anyway" button
causes "Login dialog canceled" instead of validating.
The following message (and the following bug) only occurs when the remote ssh
host isn't already into ~/.ssh folder.

The related message:
-------------------------------------------------------------
Identity Verification Failed
Verifying the identity of “[...]” failed, this happens when you log in to a
computer the first time.

The identity sent by the remote computer is "[...]". If you want to be
absolutely sure it is safe to continue, contact the system administrator.
-------------------------------------------------------------
2 buttons are available:
  - Log In Anyway
  - Cancel Login

But both of them give the following message: "Login dialog canceled"

This message's text and buttons can be seen on others software using GVFS (see
"gvfsbackendsftp.c", from the GVFS source code, this is where these messages
are located).
However into these others software the "Log In Anyway" button is correctly
handled and/or transmitted to GVFS.

I took a look into the lxqt source codes and I believe I found where and why
this bug occurs (this is the only place a QMessageBox::Question is used to
display both message and buttons from somewhere else).
It's libfm-qt/src/mountoperationquestiondialog.cpp (and its associated header
mountoperationquestiondialog_p.h).

The "done()" event handler seems to be doing right, however the closeEvent()
handler (which is going to be called soon or late, before or after done() I
don't know) is forcibly passing G_MOUNT_OPERATION_ABORTED to
g_mount_operation_reply(), without any check to avoid it in case this is not
wanted. This may be originating this issue.

Hoping this report may help,

Best regards,
Julien ROBIN


-- System Information:
Debian Release: 12.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-7-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libfm-qt12 depends on:
ii  libc6                             2.36-8
ii  libexif12                         0.6.24-1+b1
ii  libglib2.0-0                      2.74.6-1
ii  libglib2.0-bin                    2.74.6-1
ii  libmenu-cache3                    1.1.0-1.1
ii  libqt5core5a [qtbase-abi-5-15-8]  5.15.8+dfsg-3
ii  libqt5gui5                        5.15.8+dfsg-3
ii  libqt5widgets5                    5.15.8+dfsg-3
ii  libqt5x11extras5                  5.15.8-2
ii  libstdc++6                        12.2.0-14
ii  libxcb1                           1.15-1
ii  shared-mime-info                  2.2-1

Versions of packages libfm-qt12 recommends:
ii  libfm-qt-l10n  1.2.1-1

libfm-qt12 suggests no packages.

-- no debconf information