[Pkg-mozext-maintainers] feedback on noscript 1.9.9.63-1

[Daniel Kahn Gillmor]

Hi arno--

I just did a quick look at:

 
http://mentors.debian.net/debian/pool/main/m/mozilla-noscript/mozilla-noscript_1.9.9.63-1.dsc

It looks pretty good!  Thanks for working on it, and making such a nice 
clean package.

Some nit-picky observations/thoughts:

  0) you might want to explicitly make a get-orig-source target in 
debian/rules.  you've already got the groundwork laid there, and i think 
get-orig-source is the preferred target name according to policy

  1) your debian/copyright file is very close to being compliant with 
DEP5 -- i think you just need some headers to bring it into compliance.

  2) you can probably remove some of the boilerplate comments in 
debian/rules -- i don't think they're required for attribution, and 
they're more to wade through if folks want to understand what you're doing.

  3) debian/patches/0003* looks like it might be a difficult patch to 
maintain if upstream changes in any explicit way.  might it be better 
done as a sed -i script in the debian/rules target that re-packs the 
upstream tarball, since it has to do with the placement of the unpacked 
locales files (and the unpacked locales files are extracted in that same 
target)?  maybe other folks will disagree with me on this, but it seems 
like you'd get cleaner long-term packaging in that way, and i don't 
think you'd really violate the idea of "what is upstream source", since 
that file appears to be generated anyway.

  4) You could fold in the removal of NoScript_License.txt to your 
invocation of install-xpi by using -x -- it seems cleaner to me, but it 
probably doesn't matter much.

  5) i don't think you need --with quilt in your % target invocation of 
dh, since debian/source/format explicitly says "3.0 (quilt)"

  6) You also don't need to build-depend on quilt, since you're using 
the new source format.

  7) Your default configuration file doesn't have any (commented) 
references for where admins might look to find other preferences they 
might want to override.  Also, you explicitly override some preferences 
in debian/patches/0000{1,2}*.  I wonder why those are overridden there, 
but the other preference is overridden in xul-ext-noscript.js.  Maybe 
they should all be done in the same way?  If not, maybe it would be good 
to include an explanation of why you chose to patch out some preferences 
and override some others.

Thanks for your work on noscript, it's great to see it tracking upstream 
this closely in debian.

	--dkg