[Pkg-mozext-maintainers] feedback on noscript 1.9.9.63-1

[arno]

Le samedi 17 avril 2010, à 20:01:49 -0400, Daniel a écrit : 
> Hi arno--
> 
> I just did a quick look at:
> 
> 
> http://mentors.debian.net/debian/pool/main/m/mozilla-noscript/mozilla-noscript_1.9.9.63-1.dsc


Hi, thanks for your feedback.

> Some nit-picky observations/thoughts:
> 
>  0) you might want to explicitly make a get-orig-source target in
> debian/rules.  you've already got the groundwork laid there, and i
> think get-orig-source is the preferred target name according to
> policy

done

>  1) your debian/copyright file is very close to being compliant with
> DEP5 -- i think you just need some headers to bring it into
> compliance.

why not, I've not done that yet, but may be I should. Are there already some 
tools that parse and uses those machine readable copyright files ?

>  2) you can probably remove some of the boilerplate comments in
> debian/rules -- i don't think they're required for attribution, and
> they're more to wade through if folks want to understand what you're
> doing.

done

>  3) debian/patches/0003* looks like it might be a difficult patch to
> maintain if upstream changes in any explicit way.  might it be
> better done as a sed -i script in the debian/rules target that
> re-packs the upstream tarball, since it has to do with the placement
> of the unpacked locales files (and the unpacked locales files are
> extracted in that same target)? 

good idea, I've changed that

>  4) You could fold in the removal of NoScript_License.txt to your
> invocation of install-xpi by using -x -- it seems cleaner to me, but
> it probably doesn't matter much.

done

>  5) i don't think you need --with quilt in your % target invocation
> of dh, since debian/source/format explicitly says "3.0 (quilt)"

If don't use --with quilt debclean does not unapply patches.

>  6) You also don't need to build-depend on quilt, since you're using
> the new source format.

and if I use --with quilt without this build depends, lintian is not happy

>  7) Your default configuration file doesn't have any (commented)
> references for where admins might look to find other preferences
> they might want to override. 

Do you think I should copy all preferences from 
default/preferences/noscript.js ?

> Also, you explicitly override some
> preferences in debian/patches/0000{1,2}*.  I wonder why those are
> overridden there, but the other preference is overridden in
> xul-ext-noscript.js.  Maybe they should all be done in the same way?
> If not, maybe it would be good to include an explanation of why you
> chose to patch out some preferences and override some others.

The preference I set in /etc/xul-ext/noscript.js is not already defined by 
noscript. The others are defined in noscript, and I override them. That's why 
I treat them differently, but may it's better to put them all in 
/etc/xul-ext/noscript.js, then, I would have no patch anymore.

My current progress is available at:
http://mentors.debian.net/debian/pool/main/m/mozilla-noscript/mozilla-noscript_1.9.9.66-1.dsc

arno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-mozext-maintainers/attachments/20100419/58b9326e/attachment.pgp>