[Pkg-mozext-maintainers] RFS: stylish/1.3.1+git20130115-1 [ITP]
Benjamin Drung
bdrung at debian.org
Thu Jan 31 15:05:14 UTC 2013
Am Samstag, den 26.01.2013, 12:57 +1100 schrieb Dmitry Smirnov:
> Dear colleagues,
>
> Packaging of "xul-ext-stylish" is finished so perhaps it's ready for upload.
>
> I had to rebuild some .xpt files using xulrunner-dev -- I've never done it
> before so brief review will be appreciated.
>
> Source package is available from:
>
> https://mentors.debian.net/package/stylish
>
> Package repository is:
>
> http://anonscm.debian.org/gitweb/?p=pkg-mozext/stylish.git
>
> ITP Bug:
>
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697897
>
> Thank you.
I did a review:
1) get-orig-source generates a tarball that differs in the
stylish/ChangeLog file.
2) Please run wrap-and-sort (the build dependencies are strangely
formatted).
3) Please add a minimum version for the mozilla-devscripts build
dependency: http://wiki.debian.org/mozilla-devscripts
4) Why do you set --max-parallel=4 in debian/rules?
--
Benjamin Drung
Debian & Ubuntu Developer
More information about the Pkg-mozext-maintainers
mailing list