[Pkg-mozext-maintainers] RFS: stylish/1.3.1+git20130115-1 [ITP]

[Dmitry Smirnov]

On Fri, 1 Feb 2013 02:05:14 Benjamin Drung wrote:
> I did a review:

Thanks!

> 1) get-orig-source generates a tarball that differs in the
> stylish/ChangeLog file.

Differs?
It generates ChangeLog (if not present). This is intentional.
Where/why do you see a problem?


> 2) Please run wrap-and-sort (the build dependencies are strangely
> formatted).

No thanks. I found wrap-and-sort to generate incorrect results in some cases.
I don't trust this tool because sometimes it drops valid fields (#694142) and 
I don't even like it because it produces weird sorting that goes against 
common sense.

As you can see "strange formatting" is intentional and VCS-friendly.
What's the problem?

You can always run wrap-and-sort if I retire from maintenance of this package.

I think we already had this discussion.

Please don't make usage of wrap-and-sort requirement for packaging.
As far as I'm aware no other teams insist on using wrap-and-sort.

> 3) Please add a minimum version for the mozilla-devscripts build
> dependency: http://wiki.debian.org/mozilla-devscripts

You meant "mozilla-devscripts (>= 0.22~)" right?

Perhaps that's unnecessary as we have 0.23 in stable.
Besides we didn't do it for https-finder.

I prefer to leave as is.


> 4) Why do you set --max-parallel=4 in debian/rules?

Safety. Once I had experience with FTBFS on 6 cores when it was all fine on 4 
cores. I can't attempt to build on more than 4 cores so I limited to 
known/proven/working configuration that I actually tested. Perhaps too 
paranoid in this case but you never know and it's better to be safe than 
sorry...

Having said that, perhaps it's not too important for this package.

Best wishes,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B