[Pkg-mozext-maintainers] BoF or Sprint while DebCamp or DebConf?

Ximin Luo infinity0 at debian.org
Thu Aug 2 06:04:00 BST 2018


Dmitry Smirnov:
> On Thursday, 2 August 2018 1:13:00 PM AEST Ximin Luo wrote:
>> I did some more tests and I think we can rely on touch-during-the-build for
>> now, and avoid touch-during-postinst.
>> [...] 
>> This sequence of events suggests that firefox is caching the timestamp of
>> manifest.json and comparing it with the previously-stored value, and *not*
>> "the time it previously checked the files". So downgrading also works with
>> an older timestamp.
> 
> Downgrading was one of my concerns but there are more (see my other email) 
> such as package reinstall and quick maintainer's re-build of the package 
> without touching changelog.
> 

Maintainers could `sudo touch` their own files, which is what I did before.

> 
>> I agree it's a bit more annoying for maintainers to deal with edits like
>> this, but we can hopefully document this more clearly somewhere. Avoiding
>> postinst I think is a worthy enough goal to put up with this.
> 
> I think it is better to touch manifest from postinst because it guarantees to 
> reload extension every time.
> 
> If extension have symlinks to other packages then even "dpkg-reconfigure" 
> would not be enough to pick up changes in other packages without touching 
> manifest from postinst. IMHO your approach would not be reliable for more 
> complex extensions with external dependencies.
> 

If extensions have symlinks to other packages, touching on postinst is not going to help either, you will need to do something much more complex.

Is this really going to be a common scenario? To deal with it, we will need to set up a dpkg trigger to walk the tree every time it is updated, and touch manifest.json to the latest timestamp out of all the files in the tree. (On the plus side, this solution also avoids postinst scripts in the webext package(s) themselves.)

> Where did you push your changes? webext-devscripts repository is not updated 
> yet:
> 
>   https://salsa.debian.org/webext-team/webext-devscripts
> 

I already implemented touching manifest.json during the build yesterday, so the repo is already updated.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git



More information about the Pkg-mozext-maintainers mailing list