[Pkg-mozext-maintainers] [Enigmail] failing test suites on debian infrastructure

Daniel Kahn Gillmor dkg at fifthhorseman.net
Tue Jul 10 16:27:17 BST 2018


On Tue 2018-07-03 08:37:46 +0200, Patrick Brunschwig wrote:
> On 02.07.18 20:51, Daniel Kahn Gillmor wrote:
>> If it's NS_ERROR_STORAGE_BUSY, i note that there are several different
>> points where thunderbird appears to just wait 10 seconds and retry when
>> sqlite is complaining that it's busy...
>> 
>>    https://codesearch.debian.net/search?q=package%3Athunderbird+NS_ERROR_STORAGE_BUSY
>> 
>> Maybe enigmail should adopt the same workarounds?  they're kind of ugly,
>> but i don't know what else to do.
>> 
>> or, is there some other scenario i should look into?
>
> I will look into it. Probably there is nothing else we can do.

Thanks to help from Patrick, and from some good people on the #debci
channel on irc.oftc.net, we've worked around this issue by ensuring that
opening the Autocrypt sqlite db is retried intermittently (for up to 10
seconds) if it fails.

Patrick also identified several other minor concerns about the test
suite, where it was behaving differently on different platforms, and has
tuned either the code or the test suite to simplify and clarify.

As a result, i can now say that the test suite passes correctly on the
debian infrastructure:

    https://ci.debian.net/packages/e/enigmail/

Moreover, it turned out to be relatively simple to remove OpenPGP.js
from the 2.0 branch and still pass the test suite (though it depends on
a very modern version of GnuPG, including patches that are expected to
land upstream in GnuPG 2.2.9), so a re-packaged, OpenPGP.js-free
Enigmail is in Debian unstable as of this morning, and should be on its
way back into debian's testing distribuation.

I'm trying to further clean up the enigmail-2.0-branch, to make it
easier to reason about and hack on.

Part of that cleanup is in these two merge requests for the 2.0 branch:

  https://gitlab.com/enigmail/enigmail/merge_requests/13
  https://gitlab.com/enigmail/enigmail/merge_requests/14

I also recommend a review and removal of all unnecessary python and perl
code in util/:

  https://sourceforge.net/p/enigmail/bugs/880/

I am working on getting the test suite to run on gitlab infrastructure
as well so that we can have replicated results.

   --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-mozext-maintainers/attachments/20180710/2e680e97/attachment.sig>


More information about the Pkg-mozext-maintainers mailing list