[Pkg-mozext-maintainers] Bug#908509: Missing build-dependency against python(3)

[Markus Koschany]

Control: tags -1 confirmed pending

Am 10.09.2018 um 18:28 schrieb Laurent Bigonville:
> Package: webext-ublock-origin
> Version: 1.16.14+dfsg-1
> Severity: serious
> 
> Hi,
> 
> Looking at the build logs, it seems that the buildsystem is using both
> python and python3 (*sigh*) but none of them are declared in the build
> dependency.

Thank you for reporting this issue. Indeed a build-dependency on python3
is missing. The python command should not be necessary in my opinion and
could be replaced with python3. Seems to be a bit inconsistent. I will
raise this issue with upstream.

> The main visible issue is that the version is not properly set in the
> manifest, but I don't know if there are not other issues.

Apparently there are no obvious usability issues but the "web accessible
resource" feature did not work as intended because of this bug. If I
read src/web_accessible_resources/to-import.txt correctly, ublock-origin
used a fallback mechanism instead.

> The build script should also probably be called with bash -e to exit if
> anything fails during the build

Good idea. I will implement that.

Regards,

Markus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-mozext-maintainers/attachments/20180910/f8046d75/attachment.sig>