[Pkg-mozext-maintainers] Bug#975115: Wrong API version string in Debian packaged tbsync extension

[Jan-Marek Glogowski]

Hi everyone,

just installed webext-dav4tbsync on buster (incl. tbsync 2.18-1~deb10u1) 
and was bitten by this bug.

Then I downloaded tbsync 2.18 from TB addons, unzip'ed both tbsync xpi 
and ran a diff on them:

Only in orig/: CONTRIBUTORS.md
Only in orig/: LICENSE
Only in orig/: README.md
Only in orig/_locales: Readme.txt
diff -urb orig/content/modules/providers.js 
dpkg/content/modules/providers.js
--- orig/content/modules/providers.js   2020-08-28 18:07:42.000000000 +0200
+++ dpkg/content/modules/providers.js   2020-10-16 13:38:49.000000000 +0200
@@ -14,10 +14,10 @@
    defaultProviders: {
      "dav" : {
        name: "CalDAV & CardDAV",
-      homepageUrl: "https://addons.thunderbird.net/addon/dav-4-tbsync/"},
+      homepageUrl: 
"https://tbsync.jobisoft.de/beta/TB78/DAV-4-TbSync.xpi"},
      "eas" : {
        name: "Exchange ActiveSync",
-      homepageUrl: "https://addons.thunderbird.net/addon/eas-4-tbsync/"},
+      homepageUrl: 
"https://tbsync.jobisoft.de/beta/TB78/EAS-4-TbSync.xpi"},
    },

    loadedProviders: null,
diff -urb orig/content/tbsync.jsm dpkg/content/tbsync.jsm
--- orig/content/tbsync.jsm     2020-10-16 12:50:02.000000000 +0200
+++ dpkg/content/tbsync.jsm     2020-10-16 13:38:49.000000000 +0200
@@ -27,7 +27,7 @@
    addon: null,
    version: 0,
    debugMode: false,
-  apiVersion: "2.4",
+  apiVersion: "Beta 2.4",

    prefs: Services.prefs.getBranch("extensions.tbsync."),

diff -urb orig/manifest.json dpkg/manifest.json
--- orig/manifest.json  2020-10-16 13:40:28.000000000 +0200
+++ dpkg/manifest.json  2020-10-16 13:38:49.000000000 +0200
@@ -1,13 +1,14 @@
  {
    "applications": {
      "gecko": {
+  "update_url": "https://tbsync.jobisoft.de/beta/TB78/update-tbsync.json",
        "id": "tbsync at jobisoft.de",
        "strict_min_version": "78.0",
        "strict_max_version": "78.*"
      }
    },
    "manifest_version": 2,
-  "name": "TbSync",
+  "name": "TbSync [Beta Release Channel]",
    "version": "2.18",
    "author": "John Bieling",
    "homepage_url": "https://github.com/jobisoft/TbSync",

After that I replaced the dpkg included tbsync at jobisoft.de.xpi with the 
TB addons download and got no more error.

HTH

Jan-Marek