[Pkg-mpd-maintainers] MPD 0.21 in buster

Florian Schlichting fsfs at debian.org
Wed Dec 5 22:18:43 GMT 2018


Hi kaliko,

On Sat, Nov 17, 2018 at 02:17:47PM +0100, kaliko wrote:
> follow-up,
> 
> On 15/11/2018 16:53, kaliko wrote:
> > I've started packaging v0.21 on my side
> > […]
> > I published it on salsa if you want to have a look:
> > 
> > https://salsa.debian.org/kaliko-guest/mpd/tree/master-0.21

I've had a look and tested the build; and given that there are several
people who have voiced their interest for 0.21 in one way or another, I
think we should perhaps move forward.

> The meson build does not expose option for tremor [0].

> [0] https://github.com/MusicPlayerDaemon/MPD/issues/405

hmm, this could make people unhappy. Should we wait to see if there's
progress, and for how long? I could do an upload to experimental soon,
so interested people can test and we can check for build issues on
uncommon architectures.

> I just commented out that part in d/rules and reported vorbis in
> ENABLE_FILEFORMATS.

You also enabled twolame and disabled shine for everyone. Is that on
purpose? I thought if one can have MP3 that would be preferable to MP2,
and shine is supposed to be very fast - though I never use the encoders
myself, perhaps see
http://bernaerts.dyndns.org/nas/71-dns325-ffp07/249-dns325-ffp7-ffmpeg-sox-x264-lame-shineenc-fdkaac-twolame-opus#h4-speed-test-comparison

Does anybody on Debian need sndio?

> Add build dep to enable chromaprint and pcre.
> 
> Tests require libgtest-dev.

Tests are important :-)
(and we should eventually have tests for the Debian CI / autopkgtest
framework, perhaps lift some from the libaudio-mpd-perl package?)

> Regarding documentation, why not splitting the package?

/usr/share/doc/mpd/html/ is 520K here; that's not terribly much. What
do you think about just shipping doc/user.rst and doc/plugins.rst
instead of creating HTML pages that most people will find with Google on
musicpd.org instead of accessing their local copy?


When we've sorted out these questions, do you want to clean up / rework
your repo and send a pull request, or do you want me to do it myself and
cherry pick from your work?

And as I said in the salsa merge request: I appreciate your interest in
and work on mpd! We're not working together much in the mpd-team, and if
that's going to change with new people coming in, that's certainly for
the better.

Florian




More information about the Pkg-mpd-maintainers mailing list