[Pkg-mpd-maintainers] MPD 0.21 in buster

[kaliko]

Hi,

On 05/12/2018 23:18, Florian Schlichting wrote:
> On Sat, Nov 17, 2018 at 02:17:47PM +0100, kaliko wrote:
>> follow-up,
>>
>> On 15/11/2018 16:53, kaliko wrote:
>>> I've started packaging v0.21 on my side
>>> […]
>>> I published it on salsa if you want to have a look:
>>>
>>> https://salsa.debian.org/kaliko-guest/mpd/tree/master-0.21
> 
> I've had a look and tested the build; and given that there are several
> people who have voiced their interest for 0.21 in one way or another, I
> think we should perhaps move forward.

Good :)

>> The meson build does not expose option for tremor [0].
> 
>> [0] https://github.com/MusicPlayerDaemon/MPD/issues/405
> 
> hmm, this could make people unhappy. Should we wait to see if there's
> progress, and for how long? I could do an upload to experimental soon,
> so interested people can test and we can check for build issues on
> uncommon architectures.

Well uploading to experimental to have feed back from others and testing
build is good anyway.

But regarding the tremor issue upstream I think we won't see any
progress within next months. The issue is tagged "postponed" and Max is
waiting for somebody to jump in.

How long should we wait? I believe the freeze next year is the deadline
to keep in mind (date below for information). It's quite short but
allows us to debug the packaging and I hope it'll give enough time for
users to send feed back.

------------- https://release.debian.org/ -------------
[2019-Jan-12] Transition freeze
[2019-Feb-12] Soft freeze (no new packages, no re-entry, 10-day migrations)
[2019-Mar-12] Full freeze
-------------------------------------------------------

>> I just commented out that part in d/rules and reported vorbis in
>> ENABLE_FILEFORMATS.
> 
> You also enabled twolame and disabled shine for everyone. Is that on
> purpose? I thought if one can have MP3 that would be preferable to MP2,
> and shine is supposed to be very fast - though I never use the encoders
> myself, perhaps see
> http://bernaerts.dyndns.org/nas/71-dns325-ffp07/249-dns325-ffp7-ffmpeg-sox-x264-lame-shineenc-fdkaac-twolame-opus#h4-speed-test-comparison
> 
> Does anybody on Debian need sndio?

Well shine/tremor disappeared altogether when I removed tremor, just
forgot to deal with shine.

Regarding "*lame/sndio", nothing on purpose, I just lacked of rigor
while migrating to meson :)

> Tests are important :-)
> (and we should eventually have tests for the Debian CI / autopkgtest
> framework, perhaps lift some from the libaudio-mpd-perl package?)

Indeed, there is also something to do with salsa CI to get tests done
even earlier.
I'll try to have look at this if I can.

>> Regarding documentation, why not splitting the package?
> 
> /usr/share/doc/mpd/html/ is 520K here; that's not terribly much. What
> do you think about just shipping doc/user.rst and doc/plugins.rst
> instead of creating HTML pages that most people will find with Google on
> musicpd.org instead of accessing their local copy?

Indeed, splitting is not saving much.
But I think we should ship the complete doc (especially the protocol
part) since musicpd.org exposes only the latest dev version
documentation which diverges from the currently package version.

For instance playing around with the current MPD in Stretch I had to
rebuild the protocol doc for v0.19.

> When we've sorted out these questions, do you want to clean up / rework
> your repo and send a pull request, or do you want me to do it myself and
> cherry pick from your work?

I'll push the changes we agreed on, thanks for your review.

cheers
k

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-mpd-maintainers/attachments/20181206/dcd7d06d/attachment.sig>