[Pkg-mpd-maintainers] MPD 0.22 series

[Florian Schlichting]

Hi kaliko,

> I started working on mpd 0.22 in my own repo [0] (master-0.22 branch).
> So far so good, here are a some remarks.

oh dang.

I did the same thing about a month ago, and after using it for a while
and seeing no issues, committed my changes so far and pushed everything
to salsa last week, in the hope that you or others would notice and not
repeat the same work... Only that now I see the master branch didn't
make it, only upstream / pristine-tar / tags (btw I think you forgot to
push tags to your repo?)

How do we recover from that?

Since I think reviewing upstream changes and updating d/copyright was
the most time consuming, I'm going to push my changes so far and ask you
to cherry-pick yours on top? Also, I'm still at 0.22 and haven't done
the update to .3 yet - you're welcome if you want to.

> I rename WITH_SYSTEMD WITH_LINUX since it gathers several linux options and
> not only systemd support (alsa and io_uring now).

I think this is a good idea, please cherry-pick that into master.

> I also updated debian/mpd.conf (mainly cosmetic changes).

While I can't help fixing whitespace issues myself sometimes, I think in
general it just adds noise to the git history and makes comparing files
harder. So is it really worth it? The deluser line in debian/mpd.postrm
seems to be indented too far now, is that intended?

When it comes to debian/mpd.conf, I think we should try to stay as close
as possible to upstream's doc/mpdconf.example, in order to make it
easier to spot differences and track changes over time.

> Add '--now' to 'systemctl disable' in README.Debian to ensure the service is stopped.

That seems like a sensible thing to do, however I'm chewing on #958179
all this time which is also the reason the update is not forthcoming. I
think it needs a complete rewrite, and we should perhaps pass
--no-enable and --no-start to dh_installsystemd as well as not install
mpd.desktop into the global autostart folder, so that nothing is started
or enabled by default and the local admin or user need to decide what's
most suitable for their installation? All while not affecting existing
installations...

What do you think?

> @Florian : How do you update debian/copyrigh? I did not manage to find the
> proper tool to easily spot changes from the previous release/copyright file.
> I made some changes based on lintian and what I knew to have changed, but I
> surely missed something.

I think this is hard, because ideally you have to read *all* the changes
in a new release and verify that upstream didn't sneak in a secret
backdoor or drop an unlicensed work into the tarball. I've come across
the latter (elsewhere), and I have no illusions about my abilities
regarding the former, but I do try to glance over every line of the
upstream diff, and make notes about relevant things that I encounter,
such as new config options, license changes, new or deleted files with a
license different from '*' etc. Yes it's a little bit tedious, and it
can take a looong time, but I think it's what's expected of a package
maintainer. I don't know what other people do though, mpd is by far the
largest code base that I'm maintaining in Debian...

> This is the third point release of 0.22 serie, I think we should upload it
> to potentially have some feed back before the freeze. I don't run MPD on
> testing for my everyday use (I usually backport from testing), then I did
> not have much the chance to test the release in bullseye (especially the new
> io_uring support).

As I said, I've been using that for a month now without a hitch, so
let's upgrade!

Florian