[Pkg-mpd-maintainers] MPD 0.22 series

[kaliko]

Hi Florian

Le 10/11/2020 à 15:26, Florian Schlichting a écrit :
>> I started working on mpd 0.22 in my own repo[…]
> oh dang.
> 
> I did the same thing about a month ago, […]. Only that now I see the master branch didn't
> make it, only upstream / pristine-tar / tags

I think gbp push is pushing master only when debian/changelog is "released".
On my side, if i had pull the repo i would have noticed it /o\
Anyway that's no problem as long as we move forward :)

> Since I think reviewing upstream changes and updating d/copyright was
> the most time consuming, I'm going to push my changes so far and ask you
> to cherry-pick yours on top?

Alright :)

> Also, I'm still at 0.22 and haven't done
> the update to .3 yet - you're welcome if you want to.

Please go ahead, I want to figure out what I've done with ncmpc before going any further.

>> I rename WITH_SYSTEMD WITH_LINUX since it gathers several linux options and
>> not only systemd support (alsa and io_uring now).
> 
> I think this is a good idea, please cherry-pick that into master
Done

Regarding my other "comestic" changes, I agree with the extra noise to git history, 
let's forget these changes. I made a PR upstream to update mpdconf.example and some 
other part of the documentation anyway.
Except maybe for log levels that have been renamed, s/default/notice/.

>> Add '--now' to 'systemctl disable' in README.Debian to ensure the service is stopped.
> 
> That seems like a sensible thing to do, however I'm chewing on #958179
> all this time which is also the reason the update is not forthcoming. I
> think it needs a complete rewrite, and we should perhaps pass
> --no-enable and --no-start to dh_installsystemd as well as not install
> mpd.desktop into the global autostart folder, so that nothing is started
> or enabled by default and the local admin or user need to decide what's
> most suitable for their installation? All while not affecting existing
> installations...
> 
> What do you think?

For system service, as a Debian user I'm used to have services running "out of the box" 
when installing, I don't know if its policy (did not find mention of it), other users 
are probably also accustomed to this default setup for system services, daemons, etc…
I would not recommend disabling it by default then.

Regarding user land MPD, what you've done is a good trade off IMHO. Leaving user land 
configuration disabled and documenting (debian/README.Debian) how to run MPD within 
modern desktop session is fine.

The presence of mpd.desktop is confusing though. I guess using etc/xdg/autostart is the 
way to go for non systemd users. But with systemd (correct me if I'm wrong), if user 
systemd service is disabled, the desktop session still launches an MPD process through 
autostart when the user login. I believe this should be removed to be consistent with 
the "dh_installsystemduser --no-enable".

Then debian/README.Debian is good, we may just reword/reformat it a bit.


>> @Florian : How do you update debian/copyrigh? […]
> 
> […] I don't know what other people do though, mpd is by far the
> largest code base that I'm maintaining in Debian...

Alright, thanks for your advices, someone on IRC mentioned cme as a tool to maintain 
copyrigh in debian, still need to look at it more closely.

https://github.com/dod38fr/config-model/wiki/Updating-debian-copyright-file-with-cme

Cheers
k
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x065FE53932DC551D.asc
Type: application/pgp-keys
Size: 12343 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-mpd-maintainers/attachments/20201110/2fc2dcd7/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-mpd-maintainers/attachments/20201110/2fc2dcd7/attachment-0001.sig>