[Pkg-mpd-maintainers] ncmpc 0.42

[Florian Schlichting]

Hi kaliko,

> Could someone please have a look and upload latest ncmpc (my DD application
> is processing but not through yet :)) ?

do you use lintian with experimental and pedantic switches on?
distribution in d/changelog should be set to 'unstable', and then
there's the redundant-globbing-patterns warning:

    Two globbing patterns in the same Files section in debian/copyright
    match the same file.

    This situation can occur when a narrow pattern should apply the same
    license as a broader pattern. Please create another Files section
    for the narrow pattern and place it below other patterns that
    compete for the same files.

While this is indeed pedantic, it's a nice explanation of how the list
of files can be simplified for MPD...

Anyway, I made a little use of grep (or rather ack), which showed me
files such as src/system/EpollFD.hxx which according to d/copyright
should be GPL-2+ but are in fact BSD-2-clause (probably true for entire
src/system), or src/util/FNVHash.hxx which has a copyright holder that's
not mentioned in d/copyright (doesn't need an extra paragraph, but needs
to be added to the relevant Copyright: line, same as "Max Kellermann
..." individually and anybody else you might find ... grep is your
friend!

This needs to be fixed, and while you're at it:

What about dh compat v13?

The dependency on libmpdclient-dev probably doesn't need to be
versioned, as it's satisfied in oldoldstable

The repo looks a little bit weird as the merge commits from upstream
into master seem to have been lost for 0.41 and 0.42 (but look ok for
older releases) - did you rewrite or edit out those merge commits
somehow? Probably not fixable any more now but you might want to know
how that happened...


Please excuse if I leave these notes unpolished, it's late and I'm
sleepy but don't want to postpone sending this to you.

Florian