[Pkg-mpd-maintainers] ncmpc 0.42

[kaliko]

Hi Florian

Le 10/11/2020 à 16:21, Florian Schlichting a écrit :
>> Could someone please have a look and upload latest ncmpc (my DD application
>> is processing but not through yet :)) ?
> 
> do you use lintian with experimental and pedantic switches on?
> distribution in d/changelog should be set to 'unstable'

Right, I usually keep it UNRELEASED waiting for a sponsor to review it and set it to 
unstable only when the package is actually uploaded. I'll set it to 'unstable' anyway :)

> […] 
> Anyway, I made a little use of grep (or rather ack), which showed me
> files such as src/system/EpollFD.hxx which according to d/copyright
> should be GPL-2+ but are in fact BSD-2-clause (probably true for entire
> src/system), or src/util/FNVHash.hxx which has a copyright holder that's
> not mentioned in d/copyright (doesn't need an extra paragraph, but needs
> to be added to the relevant Copyright: line, same as "Max Kellermann
> ..." individually and anybody else you might find ... grep is your
> friend!
> 
> This needs to be fixed

That was even worse, within src/system there are both GPL and BSD.
I updated the file with missing author and special cases.

> What about dh compat v13?
> 
> The dependency on libmpdclient-dev probably doesn't need to be
> versioned, as it's satisfied in oldoldstable

Done, versioned dependency and dh/13.

> The repo looks a little bit weird […] you might want to know
> how that happened...

Indeed, I feel quit ashamed of what happen, especially since I don't know what led the 
repo in that state :| I guess I've been working on this in a hurry|too late at night…
Here is the gbp I follow, as documented in salsa/ncmpc/wiki [0].

     cd ncmpc || gbp clone git at salsa.debian.org:mpd-team/ncmpc.git; cd ncmpc
     # Add remote if needed
     git remote add upstream-repo https://github.com/MusicPlayerDaemon/ncmpc.git
     git fetch upstream-repo
     gbp import-orig --uscan --pristine-tar --upstream-vcs-tag=v0.XX

I did reset a test repo to previous releases to test this workflow, and it looks ok.
I don't know how I lost these merge commits :| Need to be more careful whit next releases.

> Please excuse if I leave these notes unpolished, it's late and I'm
> sleepy but don't want to postpone sending this to you.

Thanks for taking time to review the package Florian :)

[0] https://salsa.debian.org/mpd-team/ncmpc/-/wikis/home


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x065FE53932DC551D.asc
Type: application/pgp-keys
Size: 12343 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-mpd-maintainers/attachments/20201111/cf59c9ce/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-mpd-maintainers/attachments/20201111/cf59c9ce/attachment.sig>