RFS: ffado (new package)

[Adrian Knoth]

On Sun, Apr 19, 2009 at 01:51:39PM +0200, Free Ekanayaka wrote:

> Hi Adrian,

Hi!

> 1) I noticed an external/ tree in the source, which seems to ship some
> third-party libraries. You should mention this in the debian/copyright
> file, adding copyright notice for each external component.

Ok, dbus is LGPL, libconfig is GPL. I'll address this issue in the
master branch.

> 2) The source package contains the .svn directories of your svn
> checkout. I recommend using svn export or removing the .svn
> directories before generating the original tarball.

I've removed them. Original idea was to keep track via "svn update",
though it's not that hard with git-import-orig.

> 3) There's no upstream branch in the git repository, this makes it

Huu, I thought there was one:

 http://git.debian.org/?p=pkg-multimedia/ffado.git;a=shortlog;h=refs/heads/upstream

Anyway, I guess it's now fixed since the re-import via git-import-orig.


There are also some lintian warnings (ffado was my first package, and I
never checked since pushing it). I suggest I'll fix them before upload
and ping you once I have the package in a clean state.


Thanks for your comments.


Cheerio

-- 
mail: adi at thur.de  	http://adi.thur.de	PGP/GPG: key via keyserver