RFS: ffado (new package)

[Free Ekanayaka]

Hi Adrian,

|--==> On Tue, 17 Mar 2009 17:32:11 +0100, Free Ekanayaka <freee at debian.org> said:

  AK> http://git.debian.org/?p=pkg-multimedia/ffado.git;a=summary
  AK> git://git.debian.org/pkg-multimedia/ffado.git

  FE> If nobody else steps in, I will be glad to review the changes and
  FE> sponsor the upload. It just could take a few days, so bear with me :)

I finally had a chance to have a look at your package.

The package is in good shape, just a few comments:

1) I noticed an external/ tree in the source, which seems to ship some
third-party libraries. You should mention this in the debian/copyright
file, adding copyright notice for each external component.

2) The source package contains the .svn directories of your svn
checkout. I recommend using svn export or removing the .svn
directories before generating the original tarball.

3) There's no upstream branch in the git repository, this makes it
impossible to generate the .orig.gz tarball. Did you import the source
package with git-import-dsc? Maybe you just didn't push the branch.

Thanks!

Free