audacity_1.3.6-2_amd64.changes ACCEPTED

[Free Ekanayaka]

Hi Fabian,

|--==> On Mon, 12 Jan 2009 17:05:06 +0100, Fabian Greffrath <greffrath at leat.rub.de> said:

  FG> Free Ekanayaka schrieb:
  >>No problem. As you are already member of the pkg-multimedia project
  >>you should have commit access to the git repo (clone it via ssh). Feel
  >>free to make you changes and then commit, you can add yourself to
  >>Uploaders as well.

  FG> Thank you!

  FG> Let me ask some questions before I begin:

  FG> - Have you forgotten to tag the 1.3.6-2 upload?

Ouch, true! Should be there now.

  FG> - In debian/rules, lines 12 and 15 there are three arguments passed to
  FG>   ifeq. Are these syntax errors or has this been done intentionally?

Good question :) Honestly I don't know, if you could investigate the
issue further that would be very appreciated.

  FG> - In debian/rules, why are lines 36 to 38 commented out?

Probably because the Debian package used to ship a .desktop and mime
file, not present in the upstream code. The latest upstream releases
seem to fix the problem, so those lines could be deleted I suppose.

  FG> - Do you prefer if I commit my changes one by one in small steps or if
  FG>   I commit them all at once in one big step.

It would be nice to have commits that address a single problem/feature
each, with a clear commit message explaining it. If the that
particular problem/features involves several files, that's not a
problem.

I would also avoid modifying debian/changelog, and generate it just
before release the package with:

git-dch

Ciao!

Free