audacity_1.3.6-2_amd64.changes ACCEPTED

[Fabian Greffrath]

Free Ekanayaka schrieb:
> Ouch, true! Should be there now.

Hm, either I still don't understand the whole thing enough or 
debian/changelog in master is still at 1.3.5-2.

> Good question :) Honestly I don't know, if you could investigate the
> issue further that would be very appreciated.

In Makefile syntax ifeq expects two arguments not three, that's for 
sure. ;)

> Probably because the Debian package used to ship a .desktop and mime
> file, not present in the upstream code. The latest upstream releases
> seem to fix the problem, so those lines could be deleted I suppose.

However, dh_desktop is called by gnome.mk and dh_installmime is called 
by debhelper.mk, so both lines are indeed redundant.

> It would be nice to have commits that address a single problem/feature
> each, with a clear commit message explaining it. If the that
> particular problem/features involves several files, that's not a
> problem.

allright, I'll try to make as small steps as possible. ;)

> I would also avoid modifying debian/changelog, and generate it just
> before release the package with:
> 
> git-dch

Nice hint, thanks!

BTW, lintian reports that audacity has a rather big /usr/share. It 
contain s mostly plugins which I assume are arch-indep (else 
/usr/share would be the wrong place anyway), so what's you opinion on 
introducing an audacity-data_*_all package which contains these files 
and let audacity depend on it?

Fabian

-- 
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffrath at leat.ruhr-uni-bochum.de