audacity_1.3.6-2_amd64.changes ACCEPTED

[Free Ekanayaka]

Hi Fabian,

|--==> On Wed, 14 Jan 2009 10:03:34 +0100, Fabian Greffrath <greffrath at leat.rub.de> said:

  FG> Free Ekanayaka schrieb:
  >>Ouch, true! Should be there now.

  FG> Hm, either I still don't understand the whole thing enough or
  FG> debian/changelog in master is still at 1.3.5-2.

Sorry, you're right, I didn't push my changes, they should be there
now.

  >>Good question :) Honestly I don't know, if you could investigate the
  >>issue further that would be very appreciated.

  FG> In Makefile syntax ifeq expects two arguments not three, that's for
  FG> sure. ;)

So there's definitely something wrong there :)

  >>Probably because the Debian package used to ship a .desktop and mime
  >>file, not present in the upstream code. The latest upstream releases
  >>seem to fix the problem, so those lines could be deleted I suppose.

  FG> However, dh_desktop is called by gnome.mk and dh_installmime is called
  FG> by debhelper.mk, so both lines are indeed redundant.

Ok, I think you can safely remove them if you wish.

  >>It would be nice to have commits that address a single problem/feature
  >>each, with a clear commit message explaining it. If the that
  >>particular problem/features involves several files, that's not a
  >>problem.

  FG> allright, I'll try to make as small steps as possible. ;)

Thanks, IMO it doesn't matter too much if they small, but rather if
they are a consistent set of changes (the package fully works with
those changes applied), and if they introduce a single feature (the
set doesn't address conceptually separated problems, independent from
each other).

  >>I would also avoid modifying debian/changelog, and generate it just
  >>before release the package with:
  >>
  >>git-dch

  FG> Nice hint, thanks!

  FG> BTW, lintian reports that audacity has a rather big /usr/share. It
  FG> contain s mostly plugins which I assume are arch-indep (else
  FG> /usr/share would be the wrong place anyway), so what's you opinion on
  FG> introducing an audacity-data_*_all package which contains these files
  FG> and let audacity depend on it?

I've nothing against it, please just check that the plugins are all
arch-indep.

Thank you very much for your help!

Ciao,

Free