Fwd: lv2core_3.0-1_amd64.changes REJECTED

Reinhard Tartler siretart at tauware.de
Fri Jul 31 04:51:59 UTC 2009


Jaromír Mikeš <mira.mikes at seznam.cz> writes:

> FE> Sorry, maybe I'm missing something, but your changes don't seem to
> FE> address the comments of the ftpmaster? Please would you point me to
> FE> which change addresses which comment?
>
>
> I made some changes already on 9th June on debian/copyright file just
> after your uploading.

Just a general remark, I've noticed that your commit messages used to be
more descriptive when you joined the team. Your most recent commits
often read 'changed file' or 'changed some file'. It is totally clear
what files a commit already changes, but it is not clear at all what the
intentions of your patches are. This means that a reviewer needs to
actually read the patch and guess what you actually intended. For many
trivial changes it is clear, but for others, like this one, it is
not. Please try to avoid making the job of your reviewers unnecessary
hard.


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4



More information about the pkg-multimedia-maintainers mailing list