Re: Fwd: lv2core_3.0-1_amd64.changes REJECTED

Jaromír Mikeš mira.mikes at seznam.cz
Fri Jul 31 06:28:12 UTC 2009


> Od: Reinhard Tartler <siretart at tauware.de>

FE> Sorry, maybe I'm missing something, but your changes don't seem to
FE> address the comments of the ftpmaster? Please would you point me to
FE> which change addresses which comment?

JM > I made some changes already on 9th June on debian/copyright file just
JM > after your uploading.
 
RT> Just a general remark, I've noticed that your commit messages used to be
RT> more descriptive when you joined the team. Your most recent commits
RT> often read 'changed file' or 'changed some file'. It is totally clear
RT> what files a commit already changes, but it is not clear at all what the
RT> intentions of your patches are. This means that a reviewer needs to
RT> actually read the patch and guess what you actually intended. For many
RT> trivial changes it is clear, but for others, like this one, it is
RT> not. Please try to avoid making the job of your reviewers unnecessary
RT> hard.

Hi,

I will try improve my work in this way. Sorry for troubles

mira



More information about the pkg-multimedia-maintainers mailing list