Bug#645331: morituri: many unnecessary dependencies

[Julian Hughes]

On Fri, 14 Oct 2011 17:05:34 +0200
Jonas Smedegaard <dr at jones.dk> wrote:

> That is a strong accusation.  I feel offended by it.  Please relax
> your tone!
>...
> 
>  - Jonas
> 

Hi Jonas.  I'm sorry and I apologize, I didn't mean to sound so
strident. I'll rephrase that:

It made me insane(r).

I didn't need to analyse the code to suspect that a python cli CD
ripper doesn't require xpdf, or cairo, or ntfsprogs.  I noticed that it
is now in Debian and wanted to try the latest upstream version and
decided to save myself a minute and run 'apt-get build-dep' and found I
got quite a surprise  (I have built this app previous
to it being in Debian).

So I read the upstream README to check.

The requirements of morituri-0.1.1 from the author's README:

REQUIREMENTS
------------
- cdparanoia, for the actual ripping
- cdrdao, for session, TOC, pregap, and ISRC extraction
- GStreamer and its python bindings, for encoding
- python musicbrainz2, for metadata lookup
- pycdio, for drive identification (optional)

and from the latest upstream version 0.1.2:

REQUIREMENTS
------------
- cdparanoia, for the actual ripping
- cdrdao, for session, TOC, pregap, and ISRC extraction
- GStreamer and its python bindings, for encoding
  - gst-plugins-base >= 0.10.22 for appsink
- python musicbrainz2, for metadata lookup
- pycdio, for drive identification (optional)

and then I went ahead and built it (and pycdio) using only the
requirements described (and their depends) and it is fully functional
i.e. it can identify the drives, find the offset, rip the CD, encode the
extracted audio, write the files according to the naming template and
so on.  So when using only the depends suggested by the author it not
only builds but also works as intended.

As for morituri/common/taskgtk.py, it seems to be vestigial.  The author
did start morituri with the intention of creating a gtk app but after
two or three years that aspiration doesn't seem to go beyond that
redundant file and a note in the TODO.  I notice that task.py and
taskgtk.py are no longer present in morituri trunk.

To conclude, I apologise again for being abrasive, it wasn't my
intention, and hope that the package depends can be remedied for future
versions.

regards

Julian