Bug#643413: jack-tools: FTBFS: jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: jack-tools
Version: 20101210-1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> gcc -DPACKAGE_NAME=\"jack.\*\" -DPACKAGE_TARNAME=\"jack--\" -DPACKAGE_VERSION=\"0.5\" -DPACKAGE_STRING=\"jack.\*\ 0.5\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"jack--\" -DVERSION=\"0.5\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_SYS_INOTIFY_H=1 -DHAVE_INOTIFY=1 -I.    -D_POSIX_C_SOURCE=200112 -std=c99 -O3 -funroll-loops -Wall   -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c -o jack_dl-jack.dl.o `test -f 'jack.dl.c' || echo './'`jack.dl.c
> jack.dl.c: In function 'fail':
> jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
> 
> make[2]: *** [jack_dl-jack.dl.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/jack-tools_20101210-1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.