Bug#643454: pd-zexy: FTBFS: freadln.c:115:7: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: pd-zexy
Version: 2.2.3-2
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> gcc -I.  -DHAVE_CONFIG_H -DZEXY_LIBRARY -DPD   -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -mms-bitfields -fPIC   -c -o freadln.o freadln.c
> freadln.c: In function 'freadln_open':
> freadln.c:115:7: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
> 
> make[1]: *** [freadln.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/pd-zexy_2.2.3-2_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.