Bug#749659: audacity: Systematic check for Printf/Format mismatches

Martin Steghöfer martin at steghoefer.eu
Fri Oct 10 10:28:08 UTC 2014


El 09/10/14 a les 01:11, Benjamin Drung ha escrit:
> Your patch needs to be forward ported,

We already have a patch that fixes 2.0.6 for wxWidgets 3.0. Back when 
you asked me to forward-port my patch to the current svn head (in order 
to get the changes into upstream), I did. Apart from the porting it 
includes specific fixes for svn head. Fortunately, 2.0.6 isn't that 
different from what was svn head back then, so we have a patch for 
2.0.6, find it attached. To keep it small, I've removed everything that 
isn't relevant here (fixes of dead code or code that otherwise isn't 
relevant on Debian), but we will have that available for upstream. Be 
aware that this patch is by far not as well tested as my patch for 2.0.5!

> [...] backport the preliminary upstream changes for wxWidgets 3.0.1 from r13403 [...]
> [...]
> Upstream want to get wx3.0 support in for 2.0.7 and is actively working on getting it in the svn

"Actively working", yes, unfortunately. Why? Your messages sounded like 
upstream was aware of this being resolved already, especially with you 
being part of upstream (AFAIK). Not only was this a major duplication of 
effort, but now it also requires additional porting - which is mainly 
manual work here, given that different people have been working on 
similar issues and touching the same code, but in different ways. What 
we're doing here is really inefficient.


> So you could provide the missing bits and we will get
> upstream to test your proposed changes (when I commit them to the
> upstream repository).

So you're proposing to do the upstream integration first? I'd do it the 
other way round, given that for 2.0.6 we already have a patch and that 
the upstream integration has just gotten more complicated. We've already 
lost a lot of time. And before we just upload stuff to upstream, I'd 
also like to discuss the upstream integration with the person that has 
been working on wx3.0 there, especially as he has been fixing some code 
that I consider obsolete with wx3.0 and that I'd like to fix some things 
in a different way.

Cheers,
Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: audacity-2.0.6-with-wxWidgets-3.0.patch
Type: text/x-diff
Size: 74387 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20141010/e8f7c346/attachment-0001.patch>


More information about the pkg-multimedia-maintainers mailing list