Bug#749659: audacity: Systematic check for Printf/Format mismatches

[Martin Steghöfer]

Hi Benjamin!


Martin Steghöfer wrote:
> And before we just upload stuff to upstream, I'd also like to discuss 
> the upstream integration with the person that has been working on 
> wx3.0 there

Looking at the recent upstream activity, I've changed my mind about 
this: We should get this into upstream as soon as possible! Otherwise 
porting the fixes is just going to be even more difficult. Now that 
someone has made an initial commit about wxWidgets 3.0, people upgrade 
and try to fix things - but not always in the proper way.

Today's upstream commits alone justify being worried: 3 commits arrived 
upstream trying to fix wx3.0-related stuff: The first one removed 
functionality (!) in order to avoid the problems. The second one 
replaced one inadequate function call by another inadequate function 
call - which avoids the crash for the moment, but is equally wrong and 
may still crash with other compiler flags. The third one silenced a 
warning instead of fixing the underlying problem - which causes an 
invalid memory access and therefore a possible crash. With all those 
"fixes" in place, porting the patch won't only get harder (because of 
conflicts), but the diff will also become more cryptic (it's easier to 
understand a simple fix than to understand the fix of an existing fix).

So today I took the time to port my fixes (again) to the current svn 
head. I've got them sitting in my local git, divided in many commits, 
for better documentation (the Debian patch is huge and no one can tell 
any more, which change corresponds to which fix). I can send them all to 
you and you import them manually into svn. Or I can commit them directly 
to the svn - I've got git-svn set-up, I'd just need access to the 
repository. I can also send the patches to you first, for inspection 
(but it's mainly what you've seen here in the debdiff, just divided, 
ported and with non-Debian-relevant changes).

For the Debian package I still recommend the patch I've sent earlier 
today. Why bother with extra porting work and combining several patches 
(including additional porting work)?

Cheers,
Martin