Bug#786438: libmp3lame0: general protection error in libmp3lame.so.0.0.0

Fabian Greffrath fabian at debian.org
Sun Jun 7 12:48:29 UTC 2015


Hi Bernhard,

Am Sonntag, den 07.06.2015, 14:36 +0200 schrieb Bernhard Übelacker: 
> your patch fixes the issue.

\o/

> But I fear by using static we potentially introduce a race condition,
> if there are any applications encoding in two threads?

I see, maybe we could add a "security net" there (e.g. another static
variable that is set to 1 at the beginning of the function and to 0 at
the end and a "while (variable)" loop just before that at the
beginning).

> (May I ask if there are any reasons against "__attribute__((aligned(0x20)))"?)

Hm, because (a) it should not even be necessary and (b) it is not
portable to non-GCC compilers. The variables are already properly
aligned, but not if the FPU is in x387 mode.

Cheers,

Fabian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20150607/6c00f9e7/attachment.sig>


More information about the pkg-multimedia-maintainers mailing list