libgig 4.0.0 qsampler 4.2.0 gigedit 1.0.0

[James Cowgill]

Hi,

On 01/12/16 23:48, Jaromír Mikeš wrote:
> 2016-12-02 0:16 GMT+01:00 James Cowgill <jcowgill at debian.org>:
>> Uploaded!
> 
> Thank you James !!! Can you review also gigedit now and give me DM flag for it?
> I think then I can upload it to experimental myself.

d/patches
Again, Makefile.in and configure are generated files so they should not
need to be edited in the 01-makefiles.patch.

d/control
> libgig-dev (>= 4.0.0~)
I think (>= 4.0.0) is enough here. You only need a ~ at the end if you
need a dependency on a specific debian revision (for backports) or a
pre-release upstream version.

d/changelog
> * Don't sign tags?
Why? I believe it's multimedia team policy to sign all debian/ tags.

d/rules
> override_dh_auto_test:
Is this necessary anymore?

Why do we need to ship the static or shared libraries? We could pass
--disable-shared and then ship nothing in /usr/lib as everything will be
compiled into /usr/bin/gigedit.

I've given you the DM flag anyway - I trust you can fix these things.

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20161202/4000ae51/attachment.sig>