libgig 4.0.0 qsampler 4.2.0 gigedit 1.0.0

[Jaromír Mikeš]

2016-12-02 12:52 GMT+01:00 James Cowgill <jcowgill at debian.org>:
> On 01/12/16 23:48, Jaromír Mikeš wrote:

Hi,

>> Can you review also gigedit now and give me DM flag for it?
>
> d/patches
> Again, Makefile.in and configure are generated files so they should not
> need to be edited in the 01-makefiles.patch.

Done!

> d/control
>> libgig-dev (>= 4.0.0~)
> I think (>= 4.0.0) is enough here. You only need a ~ at the end if you
> need a dependency on a specific debian revision (for backports) or a
> pre-release upstream version.

Done!

> d/changelog
>> * Don't sign tags?
> Why? I believe it's multimedia team policy to sign all debian/ tags.

I am not sure that it is multimedia team policy to sign tags ...
I have seen that others was removing this entry from gbp.conf file so
I did the same.
It just simplifies workflow a bit.

> d/rules
>> override_dh_auto_test:
> Is this necessary anymore?

Fixed!

> Why do we need to ship the static or shared libraries? We could pass
> --disable-shared and then ship nothing in /usr/lib as everything will be
> compiled into /usr/bin/gigedit.

Done!

> I've given you the DM flag anyway - I trust you can fix these things.

Thank you!

best regards

mira