Request for review & inclusion: sonic-pi (see #796550)

Sebastian Ramacher sramacher at debian.org
Thu Feb 11 19:05:24 UTC 2016


Hi Hanno

On 2016-02-11 17:03:04, Hanno Zulla wrote:
> I believe to have fixed all issues you have listed in your review.

nocheck[1] is not honored. You'll need something like the following:

override_dh_auto_test:
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
	# run the tests here
endif

dh_auto_test at the end of the override does not seem to run anything, so there
is no need to keep it.

Cheers

[1] Sorry, I wrote notests in my last review. That was obviously wrong.
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160211/d23b74e8/attachment.sig>


More information about the pkg-multimedia-maintainers mailing list