Request for review & inclusion: sonic-pi (see #796550)
Petter Reinholdtsen
pere at hungry.com
Thu Feb 11 21:36:17 UTC 2016
I had a look at the package in git, and in general it look good.
I missed some hints in the debian/changelog file about why the version
is a repack, and where details on the packaging can be found (ie a
reference to debian/README.source). The changelog is one of the first
things I check, at least, and I suspect the ftpmasters doing the package
review is going to start there and move on to the copyright file shortly
thereafter. :)
I see in the rules file you use 'cd app/gui/qt; make clean' instead of
'make -C app/gui/qt clean. I suspect -C is a better way to do this.
Some of the clean target should possibly be sent upstream as a patch to
get the upstream clean target to remove all generated files.
I would be happy to upload/sponsor the package as it is, but suspect it
stand a better chance in the ftpmaster review if the changelog explain a
bit about the repacking and points to the README.source file.
--
Happy hacking
Petter Reinholdtsen
More information about the pkg-multimedia-maintainers
mailing list