Request for review & inclusion: sonic-pi (see #796550)

[Hanno Zulla]

Hi,

Am 11.02.2016 um 19:51 schrieb IOhannes m zmölnig (Debian/GNU):

> then please add a lintian-override documenting the reason.

Done, thanks for pointing that out.

Am 11.02.2016 um 20:05 schrieb Sebastian Ramacher:

> nocheck[1] is not honored. You'll need something like the following:

Thanks for the code snippet. Please have a look if I'm using it
correctly now.

> dh_auto_test at the end of the override does not seem to run
> anything, so there is no need to keep it.

True, but it doesn't hurt to return to the default behaviour of
dh_auto_test to avoid unexpected missing functionality in a later
release. I'd want to keep that call.

Am 11.02.2016 um 22:36 schrieb Petter Reinholdtsen:
> I missed some hints in the debian/changelog file

Added as requested.

> I see in the rules file you use 'cd app/gui/qt; make clean' instead of
> 'make -C app/gui/qt clean.  I suspect -C is a better way to do this.

Ok, fixed.

> Some of the clean target should possibly be sent upstream as a patch to
> get the upstream clean target to remove all generated files.

I'll see if I can do that.


Thanks for the review. Updated as requested.

Should I restart the gbp repo, now that it's using the
watch/uscan/repack solution instead of debian/rules get-orig-source?

Also, is it now time to move the repo from github to
http://anonscm.debian.org/cgit/pkg-multimedia/ ?

Kind regards,

Hanno