Ready for upload: guitarix, dgedit

[Mattia Rizzolo]

On Wed, Mar 16, 2016 at 01:33:33PM +0100, Víctor Cuadrado Juan wrote:
> Hi,

Hi Victor!

> I have 2 packages ready for upload[1], can someone please do it for me?:

sure thing!
but:

>  - dgedit: Minor debian-related changes.

this commit:
https://anonscm.debian.org/cgit/pkg-multimedia/dgedit.git/commit/?id=64f6a825ecf2a02c83298a5460e235634e4f6c63

you should read debhelper(7).  You'll find that dh(1) and all of the
dh_auto_* debhelper utilities already exports the build flags by dpkg,
there is really no need to export them manually that way in d/rules.

Can you please just remove those lines instead?

>  - guitarix: fixes FTBFS, migrates the package to the Debian Multimedia
>    Team, and maybe more importantly, frees the old maintainer from
>    possibly receiving email notifications.

yay, finally I can do this in git :D

* d/changelog:
  + remove the line with the square brackets with your name, you are the
    only onw who made changes this time
  + remove that line wrt .pc in .gitignore, that's really a thing that
    won't impact the built package (nor the source) in any way
  + "fix ftbfs by moving to $(random package)", that's really
     incomprehensible.  next time please run wrap-and-sort in a separate
     commit, and then change the build-deps.  and rewrite that changelog
     line to read "Build-Depend on libwebkitgtk-dev instead of
     libwebkit-dev" or something similar, so it can be understood what
     have been done
* d/copyright:
  + I'm pretty sure the copyright years of the upstream part need to be
    updated, you wrote 2008 but the first file I opened says 2010, I'm
    confident there are even more recent files.

> I made the error of git tagging them already, sorry for that :/.

eheh, just delete them :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160316/7cc3794c/attachment.sig>