Ready for upload: guitarix, dgedit

[Víctor Cuadrado Juan]

Many thanks for the review! :)


On 16/03/16 16:53, Mattia Rizzolo wrote:
> On Wed, Mar 16, 2016 at 01:33:33PM +0100, Víctor Cuadrado Juan wrote:
> >  - dgedit: Minor debian-related changes.
>
> you should read debhelper(7).  You'll find that dh(1) and all of the
> dh_auto_* debhelper utilities already exports the build flags by dpkg,
> there is really no need to export them manually that way in d/rules.
>
> Can you please just remove those lines instead?

Thanks for the heads-up, fixed.

> >  - guitarix: fixes FTBFS, migrates the package to the Debian Multimedia
> >    Team, and maybe more importantly, frees the old maintainer from
> >    possibly receiving email notifications.
>
> yay, finally I can do this in git :D
>
> * d/changelog:
>   + remove the line with the square brackets with your name, you are the
>     only onw who made changes this time
>   + remove that line wrt .pc in .gitignore, that's really a thing that
>     won't impact the built package (nor the source) in any way
>   + "fix ftbfs by moving to $(random package)", that's really
>      incomprehensible.  next time please run wrap-and-sort in a separate
>      commit, and then change the build-deps.  and rewrite that changelog
>      line to read "Build-Depend on libwebkitgtk-dev instead of
>      libwebkit-dev" or something similar, so it can be understood what
>      have been done

Fixed.

> * d/copyright:
>   + I'm pretty sure the copyright years of the upstream part need to be
>     updated, you wrote 2008 but the first file I opened says 2010, I'm
>     confident there are even more recent files.

I have decided to drop the machine-readable copyright for now; it needs
too much work. I have updated the old d/copyright to reflect the
external copyrights and licenses that don't come from upstream's team
(and have their own readmes and licenses in their folders anyway).
Also, bumped it to 2016.


Cheers,

-- 
Víctor Cuadrado Juan           me at viccuad.me

PGP key ID: 4096R: 0xA2591E231E251F36
Key fingerprint: E3C5 114C 0C5B 4C49 BA03  0991 A259 1E23 1E25 1F36
My signed E-Mails are trustworthy.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160321/dcda2627/attachment.sig>