Ready for upload: guitarix, dgedit
Mattia Rizzolo
mattia at debian.org
Mon Mar 21 13:07:13 UTC 2016
On Mon, Mar 21, 2016 at 01:41:45PM +0100, Víctor Cuadrado Juan wrote:
> On 16/03/16 16:53, Mattia Rizzolo wrote:
> > On Wed, Mar 16, 2016 at 01:33:33PM +0100, Víctor Cuadrado Juan wrote:
> > * d/changelog:
> > + remove the line with the square brackets with your name, you are the
> > only onw who made changes this time
> > + remove that line wrt .pc in .gitignore, that's really a thing that
> > won't impact the built package (nor the source) in any way
> > + "fix ftbfs by moving to $(random package)", that's really
> > incomprehensible. next time please run wrap-and-sort in a separate
> > commit, and then change the build-deps. and rewrite that changelog
> > line to read "Build-Depend on libwebkitgtk-dev instead of
> > libwebkit-dev" or something similar, so it can be understood what
> > have been done
>
> Fixed.
>
> > * d/copyright:
> > + I'm pretty sure the copyright years of the upstream part need to be
> > updated, you wrote 2008 but the first file I opened says 2010, I'm
> > confident there are even more recent files.
>
> I have decided to drop the machine-readable copyright for now; it needs
> too much work. I have updated the old d/copyright to reflect the
> external copyrights and licenses that don't come from upstream's team
> (and have their own readmes and licenses in their folders anyway).
> Also, bumped it to 2016.
Sad, but I see your point.
Though you must have forgot to push, only the d/rules change it's there.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160321/dc259b1e/attachment.sig>
More information about the pkg-multimedia-maintainers
mailing list