Looking for uploader: qstopmotion

[Michael Stapelberg]

On Mon, Nov 14, 2016 at 9:44 PM, Adrian Knoth <adi at drcomp.erfurt.thur.de>
wrote:

> On Fri, Nov 04, 2016 at 10:12:32AM +0100, Michael Stapelberg wrote:
>
> Hi!
>
> > >    https://anonscm.debian.org/gitweb/?p=pkg-multimedia/qstopmotion.git
> >
> > I have a couple of comments which I’d like to see addressed before I can
> > upload the package :)
> >
> >    - Can you make the package largely lintian clean please? My config is
> at
>
> Done.
>

I’ll note for completeness that I’m still seeing these two lintian warnings:

I: qstopmotion: arch-dep-package-has-big-usr-share 7090kB 83%
I: qstopmotion: possible-documentation-but-no-doc-base-registration

I’m not entirely sure about the former. The files which take up most of the
space in /usr/share live in /usr/share/qstopmotion/translations. Is it
customary for Qt apps to ship their translations in that path? If so, I
suppose we can ignore the warning for now.

Please fix the latter warning about the missing doc-base, though.


>
> >    and debian-watch-may-check-gpg-signature might not be feasible. But
> can
> >    hardening be turned on?
>
> I think hardening defaults to on as of dh-compat 9, at least in
> conjunction with cmake. I do see the corresponding compiler flags set.
>

It does, but not all flags. Notably, bindnow isn’t enabled by default (but
triggers a lintian warning). Can you test+apply the following change please?

@@ -3,7 +3,7 @@


 # see FEATURE AREAS in dpkg-buildflags(1)
-#export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all

 # see ENVIRONMENT in dpkg-buildflags(1)
 # package maintainers to append CFLAGS



>
> >    - Is it common in pkg-multimedia to not use pristine-tar? If there’s
> no
>
> Nope, was an oversight. Fixed.
>
> >    - Given that it takes multiple minutes to compile, can the package be
> >    built with --parallel?
>
> It can. At least it will if DEB_BUILD_OPTIONS is set to parallel=X. Do
> you suggest to set it explicitly in debian/rules? Or do the buildds set
> it automatically?
>

Package as-is:
DEB_BUILD_OPTIONS='parallel=8' gbp buildpackage    173,88s user 17,99s
system 93% cpu 3:26,07 total

When adding --parallel to the dh call in debian/rules:
DEB_BUILD_OPTIONS='parallel=8' gbp buildpackage    167,98s user 15,37s
system 224% cpu 1:21,81 total

So, please make the following change:
@@ -13,7 +13,7 @@


 %:
-       dh $@ --buildsystem=cmake
+       dh $@ --buildsystem=cmake --parallel






>
> >    - Can you forward cmake-gphoto2.patch to upstream please?
> >    - Could you bump debian/compat to 10 please?
>
> All done.
>
> I had a mistake in the initial import (debian.patch in upstream branch),
> which is why I had to re-set the corresponding branch (read: I re-wrote
> history - bad, I know, but fortunately no other users, yet).
>
> In other words: git pull won't work, better start over with git clone.
>
>
> Cheers
>
> --
> mail: adi at thur.de       http://adi.thur.de      PGP/GPG: key via keyserver
>
>


-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20161116/8c4e1fe0/attachment-0001.html>