hydrogen packaging

[James Cowgill]

On 27/11/16 01:00, Jaromír Mikeš wrote:
> 2016-11-27 1:33 GMT+01:00 James Cowgill <jcowgill at debian.org>:
>> On 26/11/16 13:39, Jaromír Mikeš wrote:
>>> 2016-11-26 13:44 GMT+01:00 James Cowgill <jcowgill at debian.org>:
>>>> On 26/11/16 02:02, Jaromír Mikeš wrote:
>>>>> 2016-11-26 0:15 GMT+01:00 James Cowgill <jcowgill at debian.org>:
>>>>>> On 25/11/16 17:15, Jaromír Mikeš wrote:
>>>>>>> 2016-11-25 17:13 GMT+01:00 James Cowgill <jcowgill at debian.org>:
>>>>>>>> -- d/hydrogen.install
>>>>>>>>> usr/share/hydrogen/data/img
>>>>>>>> It seems that the only reason for putting this in hydrogen instead of
>>>>>>>> hydrogen-data is the SVG icon?
>>>>>>>
>>>>>>> Yes
>>>>>>
>>>>>> I don't think you should ship the entire data/img directory in the
>>>>>> hydrogen package just for this. Either only install that one svg and
>>>>>> move everything over to the -data package, or duplicate the svg since
>>>>>> it's only 9kB.
>>>>>
>>>>> Ok ... I thought that icon make sense to be installed in binary package
>>>>> but as hydrogen package can't be installed without hydrogen-data package
>>>>> all img dir is now moved to -data package.
>>>>
>>>> I agree that putting the icon in the main package does make sense - it
>>>> just seemed like a lot of other stuff could have gone in the data
>>>> package. One thing is that appstream (ie GNOME software center) requires
>>>> the icon to be in the main package so hydrogen won't show up at the moment.
>>>
>>> Done ;)
>>
>> What you've done won't work - you've installed the same file into two
>> separate packages which have to be installed together.
> 
> Now h2-icon.svg file excluded from hydrogen-data package and installed
> only in hydrogen package.

Ok just going over a few other things I spotted.

CXXFLAGS is clobbered in CMakeLists.txt:109

These files exist in debian/tmp but are not installed anywhere. The
appdata one must go in the hydrogen package for the same reason as the
icon has to.

/usr/share/appdata/hydrogen.appdata.xml
/usr/share/man/man1/hydrogen.1

Your new debian/copyright file seems to contain some C++ code which
should not be there.

Other than that I think it's OK to upload assuming I don't find anything
else :)

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20161127/578ba474/attachment.sig>