Re: phasex – request for review

Fri Dec 29 13:42:32 UTC 2017

2017-12-29 13:46 GMT+01:00 Gabor Karsay <gabor.karsay at gmx.at>:

Hi Gabor,

> I fixed the watch file for phasex and I'm asking for a review/upload.
> Maybe mira? You have listed yourself as uploader.
>
> Amongst other thing I also migrated to automatic debug packages following
> this guide: https://wiki.debian.org/AutomaticDebugPackages

Lintian says:
$ lintian -IE --pedantic --no-tag-display-limit
../phasex_0.14.97-3_amd64.changes
P: phasex source: package-uses-old-debhelper-compat-version 10
W: phasex source: newer-standards-version 4.1.3 (current is 4.1.2)
I: phasex source: testsuite-autopkgtest-missing
P: phasex source: debian-watch-may-check-gpg-signature
I: phasex: spelling-error-in-binary usr/bin/phasex GNU Public License GNU
General Public License
I: phasex: arch-dep-package-has-big-usr-share 10320kB 95%
W: phasex: binary-without-manpage usr/bin/phasex
W: phasex: binary-without-manpage usr/bin/phasex-convert-patch
I: phasex: desktop-entry-lacks-keywords-entry
usr/share/applications/phasex.desktop

So I would go with dh compat 11 now and keep standards version 4.1.2 until
lintian will recognize 4.1.3
Also I would fix desktop file ... we are shipping our one in debian dir.

d/rules
override_dh_strip:
dh_strip --dbgsym-migration='phasex-dbg (<< 0.14.97-3~)'

This seems to be redundant I believe with compat 10 and higher.

You could add yourself to uploaders in d/control file and also add hint to
d/copyright file about your contribution ...
Files: debian/*
Copyright: 2010-2013 Alessio Treglia <alessio at debian.org>
License: GPL-3+

Please remove me from uploaders list as I never started work on this
package and at the moment I am maintaining quite big number of packages.

let me know when these are fixed and I will check again.

best regards

mira

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20171229/5f63a97c/attachment.html>