[debian-mysql] Bug#745135: Top 10 reasons you should sponsor MariaDB 10.0 into Debian this weekend (Re: Bug#745135: RFS: mariadb-10.0/10.0.13-1 [ITP] -- Latest version of worlds most popular non-Oracle database)

[Otto Kekäläinen]

Hello Tobias and thanks for the review!

2014-09-23 22:49 GMT+03:00 Tobias Frost <tobi at frost.de>:
> Hi Otto,
>
> (as said, huge package, so I won't make a complete review in one run; as
> usual when I review, here's an unsorted list of things I saw.
> When I write "nitpick" that means that I leave it up you if you'd like
> to act.)
>
> - one patch has some fuzzyness -- maybe you should quilt refresh it:
> Applying patch 38_scripts__mysqld_safe.sh__signals.diff
> patching file scripts/mysqld_safe.sh
> Hunk #3 succeeded at 794 (offset 1 line).

Done.

> - I'd recommend to continue the numbering scheme with the patches you
> add, for the symmetrie of things (nitpick)

I was planning to adopt the newer style of patch naming. I now
completed it to make sure they all follow the same scheme.

> - Debconf-po Maybe also start an call for translations again. (nitpick;
> we can always do an subsequent upload when new translations come in)

There hasn't been any string updates for a long time and I think all
po files are up-to-date. I did get translations for 5.5 after I
changed some strings and I have copied those new po files into 10.0
too.

> - Please line-wrap README.Maintainer. It might be that the content
> should be also reviewed, to see if it is still applicable (like the 5.5
> references, the DEB_BUILD_OPTIONS, the gbp branch layout is already well
> described via the gbp.conf and as the gbp is now quite standard, the
> description how to import a new version might also be not needed.
> (mostly nitpick, but it should be at least updated to a 10.0 scenario)
> (Probably you could just let this file go.)

I cleaned up the file. I don't want to remove it as it is useful for
both myself and anybody who wants to do a quick security update, or
make a patch and be able to do identical builds, or that file can even
be useful for upstream later if they decide to adopt the new Debian
packaging I've done. It's just one small text file so it should not
hurt anything.

> - autobake-deb.sh.. Might be also an deletion candidate...

This is inherited from upstream and I've modified it so be compatible
with my new packaging. I'll plan to keep it there and have it in a
workable state as down the road it will make it easier when I start
sending my Debian packaging work to upstream for inclusion. Upstream
has a nice continuous integration system using Buildbot and it would
be a huge time saver for me if upstream would use my Debian packaging
and be able to immediately spot if they do changes that break
something in the Debian packages (which are generated as part of their
testing process).

At the moment upstream only checks that their new code works with
their old Debian packaging, which does not help me in any way.  I hope
this will be streamlined once I get around to send the new Debian
packaging for upstream to use.

> - d/control: Are "Uploaders" up to date? I wonder, because there is a DD
> listed which contradicts the need for sponsorship.

Done.

> - d/control: Standard-Version: Policy 3.9.6 has just been released.. Can
> you update?

Done.

> - d/control: I'd add to mariadb-test as short description what is the
> test package about.. To avoid the need that the user has to perform an
> extra search to find out; same with -client and -server.
> Can be as short as e.g "mariadb-10.0-test is the regression test suite
> for mariadb"

Both mariadb-test and mariadb-test-10.0 have a good description field.
Or did I miss something?

> - d/copyright: It refers to a README.Source which does not exists.
> (beside that, I did not a d/copyright review; so thats a TODO)

Thanks for spotting. This was copied from the mysql-5.6 package (my
mariadb packaging is based on what mysql-5.6 packaging was 1,5 years
ago) but it does not apply for MariaDB so I removed it.

See git log for details about all the changes I did today:
http://anonscm.debian.org/cgit/pkg-mysql/mariadb-10.0.git/log/

I will now start my build script to verify that all is still OK.


PS. Note also the stuff in
https://wiki.debian.org/Teams/MySQL/MariaDBPlan#TODO - they are all
useful and I'll do them in due time, but do you think any of those
items is urgent and must be done before 10.0 is uploaded?